Benchmarks for paper #588
Merged
Benchmarks for paper #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olynch
force-pushed
the
struct-acsets-benchmarks
branch
2 times, most recently
from
750e6ec
to
847a5d4
Compare
epatters
requested changes
Mar 10, 2022
There was a problem hiding this comment.
Thanks Owen for this painstaking work on benchmarks!
Two important things should be resolved before merging:
- It looks like lots of new functions don't have unit tests. See inline comments for some of them.
- The use of
@inlines seems a bit arbitrary, although I could be missing something. In my experience, inlines are only needed to ensure constant propagation for symbols. Can we be more consistent about the use of inlines and remove any extraneous ones?
olynch
force-pushed
the
struct-acsets-benchmarks
branch
from
ab214bc
to
c0d4474
Compare
olynch
force-pushed
the
struct-acsets-benchmarks
branch
from
c0d4474
to
a0d3bc7
Compare
olynch
force-pushed
the
struct-acsets-benchmarks
branch
from
a0d3bc7
to
c526f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains updated benchmarks, along with code to generate figures for the paper. It also has a lot of miscellaneous optimizations; before this gets merged, I will look back and describe them.